Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: SingleComboBox の Story を見直し #5143

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

docs: SingleComboBox の Story を見直し #5143

wants to merge 10 commits into from

Conversation

misako0927
Copy link
Contributor

関連URL

https://smarthr.atlassian.net/browse/SHRUI-1127

概要

変更内容

確認方法

Storybook や Chromatic で確認してください。

misako0927
misako0927 commented Nov 27, 2024
View reviewed changes
...ages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/VRTSingleComboBox.stories.tsx Outdated
await userEvent.click(helpMessage[0]) // カーソルの点滅によるVRTのフレーキーを避けるためにフォーカスを移動する
}

VRT.play = playSingle
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pict以外にプルダウンの展開のためplayfunctionは残しています

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 27, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5143

commit: 0b6d0bb

@misako0927 misako0927 marked this pull request as ready for review November 27, 2024 23:46
@misako0927 misako0927 requested a review from a team as a code owner November 27, 2024 23:46
@misako0927 misako0927 requested review from oti, masa0527, Qs-F, s-sasaki-0529 and uknmr and removed request for a team, oti and masa0527 November 27, 2024 23:46
@misako0927
Copy link
Contributor Author

calendarのVRTが本日の日付の◯でflakyになっているのですが、以下の２択の修正で悩んでいます....

  1. 表示する月を過去に直す
  2. calendarに今日の日付を渡せるようにして固定する

デザインのチェック的には2が良さそうなものの、機能として今日の日付を渡すことがないと思うので、1でもいいかも、、、で甲乙つけ難く。
ご意見ありましたらいただけると幸いです。。。

@s-sasaki-0529
Copy link
Contributor

あ、しまった...。日付のことすっかり考慮してなかったです…。
前職ではテスト上では Date をモックして常に固定の日付になるようなハックをしていた覚えがありますね…。

１がベターそうかなと思いましたがシュッとできそうでしょうか…？

uknmr
uknmr reviewed Nov 28, 2024
View reviewed changes
...ages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/VRTSingleComboBox.stories.tsx Outdated Show resolved Hide resolved
...ages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/VRTSingleComboBox.stories.tsx Outdated Show resolved Hide resolved
packages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/SingleComboBox.stories.tsx Outdated Show resolved Hide resolved
packages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/SingleComboBox.stories.tsx Show resolved Hide resolved
packages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/SingleComboBox.stories.tsx Outdated Show resolved Hide resolved
packages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/SingleComboBox.stories.tsx Outdated Show resolved Hide resolved
packages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/SingleComboBox.stories.tsx Outdated Show resolved Hide resolved
...ages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/VRTSingleComboBox.stories.tsx Outdated Show resolved Hide resolved
...ages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/VRTSingleComboBox.stories.tsx Outdated Show resolved Hide resolved
@misako0927 misako0927 requested a review from uknmr December 3, 2024 01:16
s-sasaki-0529
s-sasaki-0529 reviewed Dec 10, 2024
View reviewed changes
packages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/SingleComboBox.stories.tsx
items: { control: 'object' },
selectedItem: {
control: { type: 'select' },
options: Object.keys(defaultItems),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]

細かすぎますが、Controls 上でいずれかのアイテムを選択状態にしちゃうと、それをクリアする手段がなくなってちょっとだけ困りました (単にブラウザリロードしてもURLに状態が保持されちゃうので…。)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-sasaki-0529 消えた方が使い方がわかっていいかな〜と思ったので、消えたり選択できるようにしてしまいました！
20bc809

s-sasaki-0529
s-sasaki-0529 reviewed Dec 10, 2024
View reviewed changes
packages/smarthr-ui/src/components/ComboBox/SingleComboBox/stories/SingleComboBox.stories.tsx
excludeStories: ['defaultItems', 'prefixes'],
} as Meta<typeof SingleComboBox>

export const Playground: StoryObj<typeof SingleComboBox> = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]

dropdownHelpMessage を Controls で編集しようとするとクラッシュしました。
ReactNode を取るコンポーネント全般で起こる問題なので Storybook が悪いのではって気はしますが。

Copy link
Contributor Author

@misako0927 misako0927 Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-sasaki-0529 クラッシュするのは使いづらそうなので選択式に直しました！

0b6d0bb

s-sasaki-0529
s-sasaki-0529 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@s-sasaki-0529 s-sasaki-0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍️ 細かいコメントは入れましたが、必要十分にカバーできている感じがしました！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-sasaki-0529 s-sasaki-0529 s-sasaki-0529 approved these changes

@Qs-F Qs-F Awaiting requested review from Qs-F

@uknmr uknmr Awaiting requested review from uknmr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@misako0927 @s-sasaki-0529 @uknmr